Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release v1.0.0 #7535

Merged
merged 1 commit into from
Aug 24, 2021
Merged

release v1.0.0 #7535

merged 1 commit into from
Aug 24, 2021

Conversation

nehaLohia27
Copy link
Contributor

Signed-off-by: Neha Lohia [email protected]

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

@nehaLohia27: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority labels Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nehaLohia27. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/docs area/helm Issues or PRs related to helm charts labels Aug 24, 2021
@rikatz
Copy link
Contributor

rikatz commented Aug 24, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2021
tao12345666333
tao12345666333 requested changes Aug 24, 2021
View reviewed changes
Changelog.md Outdated
@@ -1,5 +1,53 @@
# Changelog

### 1.0.0
** This is a breaking change**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
** This is a breaking change**
**This is a breaking change**

tao12345666333
tao12345666333 reviewed Aug 24, 2021
View reviewed changes
charts/ingress-nginx/Chart.yaml Outdated
# List of changes for the release in artifacthub.io
# https://artifacthub.io/packages/helm/ingress-nginx/ingress-nginx?modal=changelog
artifacthub.io/changes: |
- Fix default backend annotation and tests
- Support for Ingress object v1 and drop support for v1beta1
- Update to go 1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Update to go 1.17
- Update to go 1.17

@tao12345666333
Copy link
Member

/retest

@tao12345666333
Copy link
Member

/test pull-ingress-nginx-chart-lint

tao12345666333
tao12345666333 requested changes Aug 24, 2021
View reviewed changes
charts/ingress-nginx/Chart.yaml Outdated
@@ -2,8 +2,8 @@ apiVersion: v2
name: ingress-nginx
# When the version is modified, make sure the artifacthub.io/changes list is updated
# Also update CHANGELOG.md
version: 4.0.0-beta.3
appVersion: 1.0.0-beta.3
version: 4.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should change it to 4.0.1

@nehaLohia27
release v1.0.0
b2bc66e 
Signed-off-by: Neha Lohia <[email protected]>
tao12345666333
tao12345666333 approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2021
@rikatz
Copy link
Contributor

rikatz commented Aug 24, 2021

/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nehaLohia27, rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2021
strongjz
strongjz reviewed Aug 24, 2021
View reviewed changes
Changelog.md
- `k8s.gcr.io/ingress-nginx/controller:v1.0.0@sha256:0851b34f69f69352bf168e6ccf30e1e20714a264ab1ecd1933e4d8c0fc3215c6`

**Known Issues**
Ingress Controller only supports cluster scoped IngressClass and needs cluster wide permission for this object, otherwise it is not going to start.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have an open issues for this, can we add it here. #7502

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually #7510
But my personal opinion, we CAN merge this and add the issue as a follow up, wdyt? (otherwise all the CI is going to run again...)

Copy link
Contributor

@longwuyuan longwuyuan Aug 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7510 and #7519 are related to above comment from @strongjz I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nehaLohia27 please open a follow UP PR later adding the description proposed by @strongjz

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @rikatz would open a follow up PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened follow up PR #7536

@longwuyuan
Copy link
Contributor

/remove-area docs

@rikatz
Copy link
Contributor

rikatz commented Aug 24, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit f207702 into kubernetes:main Aug 24, 2021
@spasche
Copy link

spasche commented Aug 27, 2021

Hi,
It looks like https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/CHANGELOG.md wasn't updated for v1.0.0.
It this an oversight or was it on purpose?

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@nehaLohia27 @rchshld
release v1.0.0 (kubernetes#7535)
058693b 
Signed-off-by: Neha Lohia <[email protected]>
@coderabbitai coderabbitai bot mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikatz rikatz rikatz left review comments

@longwuyuan longwuyuan longwuyuan left review comments

@strongjz strongjz strongjz left review comments

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nehaLohia27 @k8s-ci-robot @rikatz @tao12345666333 @longwuyuan @spasche @strongjz